Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(redis):better vizualization acl redis #3602

Merged
merged 1 commit into from
Jan 19, 2024
Merged

fix(redis):better vizualization acl redis #3602

merged 1 commit into from
Jan 19, 2024

Conversation

Laure-di
Copy link
Contributor

close #2962

@codecov-commenter
Copy link

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (e110d2d) 75.86% compared to head (12bba3f) 75.84%.

Files Patch % Lines
internal/namespaces/redis/v1/custom_cluster.go 22.22% 6 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3602      +/-   ##
==========================================
- Coverage   75.86%   75.84%   -0.02%     
==========================================
  Files         180      180              
  Lines       41066    41076      +10     
==========================================
+ Hits        31153    31156       +3     
- Misses       8777     8783       +6     
- Partials     1136     1137       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Codelax Codelax added this pull request to the merge queue Jan 19, 2024
Merged via the queue into scaleway:master with commit 40964fe Jan 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Codelax Codelax Codelax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add better visualization of ACL rules in redis
3 participants
@Laure-di @codecov-commenter @Codelax